D15 6 entitlements - #21
Merged
Merged
Conversation
jstedfast
reviewed
Jan 4, 2018
| } | ||
|
|
||
| public static IEnumerable<string> GetEntitlementsKeys (this PDictionary dict) | ||
| { |
Member
There was a problem hiding this comment.
I'd just call this GetEntitlementKeys (i.e. note the lack of an 's' after Entitlement).
jstedfast
suggested changes
Jan 4, 2018
jstedfast
left a comment
jstedfast
left a comment
Member
There was a problem hiding this comment.
Just the minor change I suggested, otherwise looks good.
jstedfast
approved these changes
Jan 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need these changes in d15-6 to report more detailed telemetry about entitlements.